On Tue, 2022-01-11 at 00:48 -0800, Christoph Hellwig wrote: > On Tue, Jan 11, 2022 at 10:43:09AM +0300, Dan Carpenter wrote: > > Hello Richard Sharpe, > > > > This is a semi-automatic email about new static checker warnings. > > > > The patch bc66f6805766: "NFS: Support statx_get and statx_set > > ioctls" > > from Dec 27, 2021, leads to the following Smatch complaint: > > Yikes, how did that crap get merged? Why the f**k does a remote file > system need to duplicate stat? This kind of stuff needs a proper > discussion on linux-fsdevel. > > And btw, the commit message is utter nonsense. So firstly, there already has been a discussion of this on linux- fsdevel (and linux-kernel): https://lore.kernel.org/lkml/20160429125813.23636.49830.stgit@xxxxxxxxxxxxxxxxxxxxxx/ and the consensus at the time was that these attributes were not needed in statx. The other issue is that this is not a duplicate of stat. It's adding support for both _setting_ and reading back these attributes. The ability to supporting reading the archive bit / backup time, for example, is completely useless unless you can also set those values after backing up the file. Right now, there is no support in the VFS for setting any attributes that are not part of the standard POSIX set. -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx
