On Wed, Dec 1, 2021 at 9:06 AM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > On Wed, Nov 17, 2021 at 08:40:57AM +0200, Amir Goldstein wrote: > > On Wed, Nov 17, 2021 at 12:12 AM Ioannis Angelakopoulos > > <iangelak@xxxxxxxxxx> wrote: > > > > > > > > > > > > On Tue, Nov 16, 2021 at 12:10 AM Stef Bon <stefbon@xxxxxxxxx> wrote: > > >> > > >> Hi Ioannis, > > >> > > >> I see that you have been working on making fsnotify work on virtiofs. > > >> Earlier you contacted me since I've written this: > > >> > > >> https://github.com/libfuse/libfuse/wiki/Fsnotify-and-FUSE > > >> We had a few customer requests recently to fix inotify for network fs which reminded me of Miklos's earlier patch to fix the VFS layer, but if changes to extend inotify in userspace were also done it would be important to tie them in with network/cluster filesystems that expose change notification over their network API. Most or all major SMB servers support change notification today so it is extremely common over SMB3.1.1 (and earlier dialects as well). If you have userspace inotify libraries while we wait for changes to the VFS layer to enable remote change notification - in the interim you can use an existing fsspecific ioctl for some filesystems like cifs.ko. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/fs/cifs/ioctl.c?id=d26c2ddd33569667e3eeb577c4c1d966ca9192e2