On Tue, Dec 21, 2021 at 09:15:24AM -0800, Linus Torvalds wrote: > On Tue, Dec 21, 2021 at 8:40 AM Stefan Roesch <shr@xxxxxx> wrote: > > > > This series adds support for getdents64 in liburing. The intent is to > > provide a more complete I/O interface for io_uring. > > Ack, this series looks much more natural to me now. > > I think some of the callers of "iterate_dir()" could probably be > cleaned up with the added argument, but for this series I prefer that > mindless approach of just doing "&(arg1)->f_pos" as the third argument > that is clearly a no-op. > > So the end result is perhaps not as beautiful as it could be, but I > think the patch series DTRT. It really does not. Think what happens if you pass e.g. an odd position to that on e.g. ext2/3/4. Or just use it on tmpfs, for that matter.
