On Mon, Feb 09, 2009 at 09:55:00AM +0300, Pavel Fedin wrote:
> + if ((errorcode = asfs_allocadminspace(sb,
> &newbcontblock)) == 0 && (bh = asfs_getzeroblk(sb, newbcontblock))) {
> + struct fsBNodeContainer *bnc = (void
> *) bh->b_data;
> + struct fsBNodeContainer *bncparent =
> (void *) bhparent->b_data;
> + struct BTreeContainer *btcparent =
> &bncparent->btc;
The wrapping aside, this level of indentation makes it almost impossible
to review. Generally, lines should be kept under 80 columns. This
particular function looks like it should be split into some helper
functions, but it's hard to be constructive when it's so hard to read.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
