Re: [PATCH 07/48] iov_iter: Convert iter_xarray to use folios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +		size_t offset = offset_in_folio(folio, start + __off);	\
> +		if (xas_retry(&xas, folio))			\
>  			continue;				\
> +		if (WARN_ON(xa_is_value(folio)))		\
>  			break;					\
> +		if (WARN_ON(folio_test_hugetlb(folio)))		\
>  			break;					\
> +		while (offset < folio_size(folio)) {		\

Nit: I'd be tempted to use a for loop on offset here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux