On Wed, Dec 15, 2021 at 7:45 PM Jan Kara <jack@xxxxxxx> wrote: > > Hello Amir! > > On Mon 29-11-21 22:15:26, Amir Goldstein wrote: > > This is the 3rd version of patches to add FAN_REPORT_TARGET_FID group > > flag and FAN_RENAME event. > > > > Patches [1] LTP test [2] and man page draft [3] are available on my > > github. > > I'm sorry it took so long but I was sick for a week and a bit and so things > got delayed. I've looked through the changes and they look good to me. I've > just modified patch 9/11 to pass around just mask of marks matching the > event instead of full struct fsnotify_iter_info. I understand you wanted to > reuse the fanotify_should_report_type() helpers etc. but honestly I don't > think it was bringing much clarity. The result is pushed out to fsnotify I understand why you don't like using fsnotify_iter_info. Result looks very nice to me. Thanks, Amir.