Re: [PATCH 2/3] vmcore: Convert __read_vmcore to use an iov_iter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] vmcore: Convert __read_vmcore to use an iov_iter
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 13 Dec 2021 09:00:31 +0100
Cc: Baoquan He <bhe@xxxxxxxxxx>, Vivek Goyal <vgoyal@xxxxxxxxxx>, Dave Young <dyoung@xxxxxxxxxx>, kexec@xxxxxxxxxxxxxxxxxxx, Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Amit Daniel Kachhap <amit.kachhap@xxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-s390@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20211213000636.2932569-3-willy@infradead.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Mon, Dec 13, 2021 at 12:06:35AM +0000, Matthew Wilcox (Oracle) wrote:
> +	/* trim iter to not go beyond EOF */
> +	if (iter->count > vmcore_size - *fpos)
> +		iter->count = vmcore_size - *fpos;

Nit: iov_iter_truncate()

Otherwise this looks good from a cursory view.

References:
- [PATCH 0/3] Convert vmcore to use an iov_iter
  - From: Matthew Wilcox (Oracle)
- [PATCH 2/3] vmcore: Convert __read_vmcore to use an iov_iter
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: [PATCH 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter
Next by Date: Re: [PATCH 3/3] vmcore: Convert read_from_oldmem() to take an iov_iter
Previous by thread: [PATCH 2/3] vmcore: Convert __read_vmcore to use an iov_iter
Next by thread: [PATCH - regression] devtmpfs: reconfigure on each mount
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux