Re: [PATCH v2 2/5] binder: use wake_up_pollfree()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Benjamin LaHaise <bcrl@xxxxxxxxx>
Subject: Re: [PATCH v2 2/5] binder: use wake_up_pollfree()
From: Eric Biggers <ebiggers@xxxxxxxxxx>
Date: Tue, 7 Dec 2021 11:11:54 -0800
Cc: linux-aio@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Ramji Jiyani <ramjiyani@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Martijn Coenen <maco@xxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20211207095726.169766-3-ebiggers@kernel.org>

On Tue, Dec 07, 2021 at 01:57:23AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> wake_up_poll() uses nr_exclusive=1, so it's not guaranteed to wake up
> all non-exclusive waiters.  Yet, POLLFREE *must* wake up all waiters.

This is supposed to say "all exclusive waiters".  Same in patch 3.

- Eric

References:
- [PATCH v2 0/5] aio: fix use-after-free and missing wakeups
  - From: Eric Biggers
- [PATCH v2 2/5] binder: use wake_up_pollfree()
  - From: Eric Biggers

Prev by Date: Re: [PATCH v2 0/5] aio: fix use-after-free and missing wakeups
Next by Date: [PATCH] tracefs: Have new files inherit the ownership of their parent
Previous by thread: [PATCH v2 2/5] binder: use wake_up_pollfree()
Next by thread: [PATCH v2 3/5] signalfd: use wake_up_pollfree()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux