On Tue, Dec 7, 2021 at 7:10 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > From: Arnd Bergmann <arnd@xxxxxxxx> > > Working towards a cleaner header structure, start by moving the most > commonly embedded structures into a single header file that itself > has only a minimum set of indirect includes. At this moment, this > include structures for Ugh. I liked your 1/3 patch, but I absolutely detest this one. It makes no sense to me, and just makes that header file a completely random collection of some random structure types. And I absolutely hate how it splits out the definition of the struct from basic core infrastructure (initializers etc random inline functions) for said structures. So no. NAK on this one. I think it's a disaster. Linus