Re: Unused local variable load_addr in load_elf_binary()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 06, 2021 at 06:04:56PM -0800, Kees Cook wrote:
> On Mon, Dec 06, 2021 at 04:46:01PM +0100, Lukas Bulwahn wrote:
> > Dear Akira-san,
> > 
> > With commit 0c9333606e30 ("fs/binfmt_elf: Fix AT_PHDR for unusual ELF
> > files"), you have changed load_elf_binary() in ./fs/binfmt_elf.c in a
> > way such that the local variable load_addr in load_elf_binary() is not
> > used anymore.
> 
> EEk! yeah, this totally broke ELF randomization. this needs to be
> entirely reverted.
> 
> -- 
> Kees Cook

I think my patch doesn't affect on ELF randomization because it keeps
the way of load_addr calculation.


Akira Kawata



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux