Re: [PATCH] fs: Eliminate compilation warnings for misc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matthew,

On 11/17/21 1:19 AM, Matthew Wilcox wrote:
On Tue, Nov 16, 2021 at 04:06:11PM +0800, Tianjia Zhang wrote:
Eliminate the following clang compilation warnings by adding or
fixing function comment:

These warnings have nothing to do with clang.  They're produced by
scripts/kernel-doc:

                 if (show_warnings($type, $declaration_name) && $param !~ /\./) {
                         print STDERR
                               "${file}:$.: warning: Function parameter or member '$param' not described in '$declaration_name'\n";
                         ++$warnings;
                 }

They show up in any W=1 build (which tells you that people are not
checking their patches with W=1)


Yes, there will be this warning when compiling with W=1.

+++ b/fs/file.c
@@ -645,7 +645,7 @@ EXPORT_SYMBOL(close_fd); /* for ksys_close() */
/**
   * last_fd - return last valid index into fd table
- * @cur_fds: files struct
+ * @fdt: fdtable struct

I don't think the word 'struct' there really conveys any meaning.

I think this is already a primitive, or is there any better suggestion?

Kind regards,
Tianjia



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux