On Mon 22-11-21 11:00:36, Chengguang Xu wrote:
> From: Chengguang Xu <charliecgxu@xxxxxxxxxxx>
>
> In order to wait syncing upper inodes we need to
> call wait_sb_inodes() in overlayfs' ->sync_fs.
>
> Signed-off-by: Chengguang Xu <charliecgxu@xxxxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/fs-writeback.c | 3 ++-
> include/linux/writeback.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 81ec192ce067..0438c911241e 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2505,7 +2505,7 @@ EXPORT_SYMBOL(__mark_inode_dirty);
> * completed by the time we have gained the lock and waited for all IO that is
> * in progress regardless of the order callers are granted the lock.
> */
> -static void wait_sb_inodes(struct super_block *sb)
> +void wait_sb_inodes(struct super_block *sb)
> {
> LIST_HEAD(sync_list);
>
> @@ -2589,6 +2589,7 @@ static void wait_sb_inodes(struct super_block *sb)
> rcu_read_unlock();
> mutex_unlock(&sb->s_sync_lock);
> }
> +EXPORT_SYMBOL(wait_sb_inodes);
>
> static void __writeback_inodes_sb_nr(struct super_block *sb, unsigned long nr,
> enum wb_reason reason, bool skip_if_busy)
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index d1f65adf6a26..d7aacd0434cf 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -198,6 +198,7 @@ void wakeup_flusher_threads_bdi(struct backing_dev_info *bdi,
> enum wb_reason reason);
> void inode_wait_for_writeback(struct inode *inode);
> void inode_io_list_del(struct inode *inode);
> +void wait_sb_inodes(struct super_block *sb);
>
> /* writeback.h requires fs.h; it, too, is not included from here. */
> static inline void wait_on_inode(struct inode *inode)
> --
> 2.27.0
>
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
