On 11/23/21 18:10, Stefan Roesch wrote:
This adds the use_fpos parameter to the iterate_dir function. If use_fpos is true it uses the file position in the file structure (existing behavior). If use_fpos is false, it uses the pos in the context structure.
Looks sane, one question below
This change is required to support getdents in io_uring. Signed-off-by: Stefan Roesch <shr@xxxxxx> --- fs/exportfs/expfs.c | 2 +- fs/nfsd/nfs4recover.c | 2 +- fs/nfsd/vfs.c | 2 +- fs/overlayfs/readdir.c | 6 +++--- fs/readdir.c | 28 ++++++++++++++++++++-------- include/linux/fs.h | 2 +- 6 files changed, 27 insertions(+), 15 deletions(-)
[...]
diff --git a/fs/readdir.c b/fs/readdir.c index 09e8ed7d4161..8ea5b5f45a78 100644 --- a/fs/readdir.c +++ b/fs/readdir.c @@ -21,6 +21,7 @@ #include <linux/unistd.h> #include <linux/compat.h> #include <linux/uaccess.h> +#include "internal.h"
Don't see this header is used in this patch. Just to be clear, it is here only for 2/3, right? [...] -- Pavel Begunkov
