On Tue, Nov 23, 2021 at 06:56:29PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig <hch@xxxxxx> wrote: > > > > Prepare from removing the block_device from the DAX I/O path by returning > > s/from removing/for the removal of/ Fixed. > > td->dm_dev.bdev = bdev; > > - td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev); > > + td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev, &part_off); > > Perhaps allow NULL as an argument for callers that do not care about > the start offset? All callers currently care, dm just has another way to get at the information. So for now I'd like to not add the NULL special case, but we can reconsider that as needed if/when more callers show up.