On Fri, Nov 19, 2021 at 12:11:04PM +0800, Muchun Song wrote: > + > +/* > + * Obtain the private data passed by user through proc_create_data() or > + * related. > + */ > +static inline void *pde_data(const struct inode *inode) > +{ > + return inode->i_private; > +} > + > +#define PDE_DATA(i) pde_data(i) What is the point of pde_data? If we really think changing to lower case is worth it (I don't think so, using upper case for getting at private data is a common idiom in file systems), we can just do that scripted in one go.