On 26.10.2021 23:41, Kari Argillander wrote:
> On Tue, Oct 26, 2021 at 07:41:50PM +0300, Konstantin Komarov wrote:
>> Ctime wasn't updated after setfacl command.
>> This commit fixes xfstest generic/307
>
> When I run xfstest I get
>
> generic/307 [20:37:41][ 21.436315] run fstests generic/307 at 2021-10-26 20:37:41
> [ 23.362544] vdc:
> [failed, exit status 1] [20:37:45]- output mismatch (see /results/ntfs3/results-default/generic/307.out.bad)
> --- tests/generic/307.out 2021-08-03 00:08:10.000000000 +0000
> +++ /results/ntfs3/results-default/generic/307.out.bad 2021-10-26 20:37:45.172171949 +0000
> @@ -1,2 +1,4 @@
> QA output created by 307
> Silence is golden
> +setfacl: symbol lookup error: setfacl: undefined symbol: walk_tree
> +error: ctime not updated after setfacl
> ...
> (Run 'diff -u /root/xfstests/tests/generic/307.out /results/ntfs3/results-default/generic/307.out.bad' to see the entire diff)
>
> any ideas you get different result?
>
What are mount options for this test?
generic/307 passes with "acl" and "sparse,acl".
Can you try to locate where is "undefined symbol: walk_tree" coming from?
>> Fixes: be71b5cba2e6 ("fs/ntfs3: Add attrib operations")
>>
>> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>
>> ---
>> fs/ntfs3/xattr.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
>> index 3ccdb8c2ac0b..157b70aecb4f 100644
>> --- a/fs/ntfs3/xattr.c
>> +++ b/fs/ntfs3/xattr.c
>> @@ -992,6 +992,9 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler,
>> err = ntfs_set_ea(inode, name, name_len, value, size, flags);
>>
>> out:
>> + inode->i_ctime = current_time(inode);
>> + mark_inode_dirty(inode);
>> +
>> return err;
>> }
>>
>> --
>> 2.33.0
>>
>>
