Re: [PATCH 1/2] pipe: fix potential use-after-free in pipe_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] pipe: fix potential use-after-free in pipe_read()
From: "Leizhen (ThunderTown)" <thunder.leizhen@xxxxxxxxxx>
Date: Mon, 15 Nov 2021 14:13:44 +0800
Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <YZHhQ5uUJ06BOnJh@casper.infradead.org>
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0


On 2021/11/15 12:25, Matthew Wilcox wrote:
> On Mon, Nov 15, 2021 at 11:57:20AM +0800, Zhen Lei wrote:
>>  			if (!buf->len) {
>> +				unsigned int __maybe_unused flags = buf->flags;
> 
> Why __maybe_unused?

It's used only if "#ifdef CONFIG_WATCH_QUEUE". Otherwise, a warning will be reported.

> .
>

Follow-Ups:
- Re: [PATCH 1/2] pipe: fix potential use-after-free in pipe_read()
  - From: Matthew Wilcox

References:
- [PATCH 0/2] pipe: Fix a potential UAF and delete a duplicate line of code
  - From: Zhen Lei
- [PATCH 1/2] pipe: fix potential use-after-free in pipe_read()
  - From: Zhen Lei
- Re: [PATCH 1/2] pipe: fix potential use-after-free in pipe_read()
  - From: Matthew Wilcox

Prev by Date: Re: Kernel-4.14: With ubuntu-18.04 building rootfs images and booting gives SQUASHFS error: xz decompression failed, data probably corrupt
Next by Date: Re: xas_retry() based loops on PREEMPT_RT.
Previous by thread: Re: [PATCH 1/2] pipe: fix potential use-after-free in pipe_read()
Next by thread: Re: [PATCH 1/2] pipe: fix potential use-after-free in pipe_read()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]