On Wed, 3 Nov 2021 at 02:15, Peng Hao <flyingpenghao@xxxxxxxxx> wrote: > > The 'written' that generic_file_direct_write return through > filemap_write_and_wait_range is not necessarily sequential, > and its iocb->ki_pos has not been updated. I don't see the bug, but maybe I'm missing something. Can you please explain in detail? The patch looks good as a cleanup, but I'd very much like to know first if it fixes a bug or not. Thanks, Miklos