On Fri, Oct 22, 2021 at 06:56:07PM +0300, Konstantin Komarov wrote: > Ctime wasn't updated after setfacl command. > This commit fixes xfstest generic/307 > Fixes: be71b5cba2e6 ("fs/ntfs3: Add attrib operations") Because this is fix I would suggest you make this patch 3/4. Usually fixes should be first so it is easier for stable team to pick them with confident. > > Signed-off-by: Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx> > --- > fs/ntfs3/xattr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c > index bc3144608ce1..702775a559f5 100644 > --- a/fs/ntfs3/xattr.c > +++ b/fs/ntfs3/xattr.c > @@ -994,6 +994,9 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler, > err = ntfs_set_ea(inode, name, name_len, value, size, flags, 0); > > out: > + inode->i_ctime = current_time(inode); > + mark_inode_dirty(inode); > + > return err; > } > > -- > 2.33.0 > > >