Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 21, 2021 at 01:32:19AM -0700, Christoph Hellwig wrote:
> > @@ -1436,8 +1436,8 @@ static void aio_complete_rw(struct kiocb *kiocb, long res, long res2)
> >  		file_end_write(kiocb->ki_filp);
> >  	}
> >  
> > -	iocb->ki_res.res = res;
> > -	iocb->ki_res.res2 = res2;
> > +	iocb->ki_res.res = res & 0xffffffff;
> > +	iocb->ki_res.res2 = res >> 32;
> 
> This needs a big fat comments explaining the historic context.

Oh, and please use the upper_32_bits / lower_32_bits helpers.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux