On Thu, Oct 21, 2021 at 01:32:19AM -0700, Christoph Hellwig wrote: > > @@ -1436,8 +1436,8 @@ static void aio_complete_rw(struct kiocb *kiocb, long res, long res2) > > file_end_write(kiocb->ki_filp); > > } > > > > - iocb->ki_res.res = res; > > - iocb->ki_res.res2 = res2; > > + iocb->ki_res.res = res & 0xffffffff; > > + iocb->ki_res.res2 = res >> 32; > > This needs a big fat comments explaining the historic context. Oh, and please use the upper_32_bits / lower_32_bits helpers.