On Fri, Oct 15, 2021 at 10:30:26AM +0200, Pankaj Raghav wrote: > > @@ -568,7 +569,8 @@ blk_status_t errno_to_blk_status(int errno); > > #define BLK_POLL_ONESHOT (1 << 0) > > /* do not sleep to wait for the expected completion time */ > > #define BLK_POLL_NOSLEEP (1 << 1) > Minor comment: Could we also have a flag #define BLK_POLL_SPIN 0? > It can improve the readability from the caller side instead of having > just a 0 to indicate spinning. The above are flags, so adding a define for a value is a bit counter productive.