On Fri, Jan 16, 2009 at 11:21 AM, Matthew Wilcox <matthew@xxxxxx> wrote: > On Fri, Jan 16, 2009 at 11:13:04AM +0530, Manish Katiyar wrote: >> If the unlink function is not defined by filesystem, then I think it >> is better to return operation not supported rather than saying >> permission denied, which can come from lot other places and keep user >> guessing what went wrong. I came across this while testing one of my >> small modules. > > -EOPNOTSUPP is not a valid return value from unlink(). Why ? I mean are there any issues if we return this ? Does it break anything ? > It's also > documented in the manpage: > > EPERM (Linux only) > The file system does not allow unlinking of files. English is not my first language, but still I think the above statement only means that filesystem didn't allow to unlink (whether it was actually due to permission issues or the function was not implemented is not known). > > In general, you should never use -EOPNOTSUPP. It's only for use by > networking STREAMS. Hmm.... OK, but I would like to know the reasons behind it Thanks Matthew for your comments. Thanks - Manish > > -- > Matthew Wilcox Intel Open Source Technology Centre > "Bill, look, we understand that you're interested in selling us this > operating system, but compare it to ours. We can't possibly take such > a retrograde step." > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
