Re: [PATCH 09/29] fs: simplify init_page_buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 09/29] fs: simplify init_page_buffers
From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Tue, 12 Oct 2021 23:14:14 -0700
Cc: Jens Axboe <axboe@xxxxxxxxx>, Coly Li <colyli@xxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Phillip Lougher <phillip@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx
In-reply-to: <20211013051042.1065752-10-hch@lst.de>

On Wed, Oct 13, 2021 at 07:10:22AM +0200, Christoph Hellwig wrote:
> No need to convert from bdev to inode and back.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

-- 
Kees Cook

References:
- don't use ->bd_inode to access the block device size
  - From: Christoph Hellwig
- [PATCH 09/29] fs: simplify init_page_buffers
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it
Next by Date: Re: [PATCH 10/29] affs: use bdev_nr_sectors instead of open coding it
Previous by thread: [PATCH 09/29] fs: simplify init_page_buffers
Next by thread: Re: [PATCH 09/29] fs: simplify init_page_buffers
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]