On Thu, Jan 15, 2009 at 08:41:40PM +0100, wk wrote: > Dave Chinner wrote: >> It's obviously the regression fixed by: >> >> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs.git;a=commit;h=15440319767942a363f282d6585303d3d75088ba >> >> It needs to be pushed to Linus, then into 2.6.28-stable. > > Yes, that solves the problems as expected. But may i kindly ask the xfs > fs developers to put some more readable patch here, > so that its better understandable by looking at the source code? I think > some macro would be better here, for example i used > > #define TRUNC_TO_SIGNED32(x) (x & 0x7FFFFFFF) > > inside xfs.h and replaced all "foo & 0x7fffffff" with > "TRUNC_TO_SIGNED32(foo)". >From the commit description: "The patch below is a dumb version of just putting back the masking, to make sure we have the same behavior as in 2.6.27 and earlier. I will work on a better and cleaner fix for 2.6.30." And in more detail, read the review thread: http://oss.sgi.com/archives/xfs/2008-12/msg01168.html Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
