On Thu, Oct 07, 2021 at 04:37:08PM +0200, Vlastimil Babka wrote: > > - pr_warn("%sflags: %#lx(%pGp)%s\n", type, head->flags, &head->flags, > > + pr_warn("%sflags: %#lx(%pGp)%s\n", type, head->flags.f, &head->flags.f, > > The %pGp case (here and elsewhere) could perhaps take the new type, no? > Would need to change format_page_flags() and flags_string() in lib/vsprintf.c Oh, good point. I don't think format_page_flags() would _need_ to change, but we might _want_ to change it. Particularly if we go with Al Viro's suggestion of using __bitwise to create a new type that's checked with sparse.