On Wed, Oct 06, 2021 at 04:38:49PM +0100, Matthew Wilcox wrote: > On Wed, Oct 06, 2021 at 03:22:29PM +0000, Al Viro wrote: > > On Wed, Oct 06, 2021 at 03:58:14PM +0100, Matthew Wilcox wrote: > > > David expressed some unease about the lack of typesafety in patches > > > 1 & 2 of the page->slab conversion [1], and I'll admit to not being > > > particularly a fan of passing around an unsigned long. That crystallised > > > in a discussion with Kent [2] about how to lock a page when you don't know > > > its type (solution: every memory descriptor type starts with a > > > pgflags_t) > > > > Why bother making it a struct? What's wrong with __bitwise and letting > > sparse catch conversions? > > People don't run sparse. I happen to have a built allmodconfig tree > here and running make C=2 fs/ gives 1147 lines of warnings. Why would > adding more warnings help? First of all, they are easy to grep for (they'll mention pgflags_t in warning message). What's more, we ought to reduce the amount of noise, rather than giving up on the tool and going for contortions like that...
