On Mon, Sep 27, 2021 at 09:38:01AM -0700, Luis Chamberlain wrote: > If one ends up expanding on this line checkpatch will complain that the > combination S_IRWXU|S_IRUGO|S_IXUGO should just be replaced with the > octal 0755. Do that. > > This makes no functional changes. > > Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> It could be helpful to add a link too: https://www.kernel.org/doc/html/latest/dev-tools/checkpatch.html?highlight=non_octal#permissions Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> > --- > fs/sysfs/dir.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c > index 59dffd5ca517..b6b6796e1616 100644 > --- a/fs/sysfs/dir.c > +++ b/fs/sysfs/dir.c > @@ -56,8 +56,7 @@ int sysfs_create_dir_ns(struct kobject *kobj, const void *ns) > > kobject_get_ownership(kobj, &uid, &gid); > > - kn = kernfs_create_dir_ns(parent, kobject_name(kobj), > - S_IRWXU | S_IRUGO | S_IXUGO, uid, gid, > + kn = kernfs_create_dir_ns(parent, kobject_name(kobj), 0755, uid, gid, > kobj, ns); > if (IS_ERR(kn)) { > if (PTR_ERR(kn) == -EEXIST) > -- > 2.30.2 > -- Kees Cook
