On 9/27/2021 12:20 PM, Vivek Goyal wrote: > On Mon, Sep 27, 2021 at 10:56:59AM -0700, Casey Schaufler wrote: >> On 9/27/2021 8:56 AM, Vivek Goyal wrote: >>> On Mon, Sep 27, 2021 at 08:22:48AM -0700, Casey Schaufler wrote: >>>> On 9/27/2021 7:05 AM, Vivek Goyal wrote: >>>>> On Sun, Sep 26, 2021 at 05:53:11PM -0700, Casey Schaufler wrote: >>>>>> On 9/24/2021 4:32 PM, Vivek Goyal wrote: >>>>>>> On Fri, Sep 24, 2021 at 06:00:10PM -0400, Colin Walters wrote: >>>>>>>> On Fri, Sep 24, 2021, at 3:24 PM, Vivek Goyal wrote: >>>>>>>>> When a new inode is created, send its security context to server along >>>>>>>>> with creation request (FUSE_CREAT, FUSE_MKNOD, FUSE_MKDIR and FUSE_SYMLINK). >>>>>>>>> This gives server an opportunity to create new file and set security >>>>>>>>> context (possibly atomically). In all the configurations it might not >>>>>>>>> be possible to set context atomically. >>>>>>>>> >>>>>>>>> Like nfs and ceph, use security_dentry_init_security() to dermine security >>>>>>>>> context of inode and send it with create, mkdir, mknod, and symlink requests. >>>>>>>>> >>>>>>>>> Following is the information sent to server. >>>>>>>>> >>>>>>>>> - struct fuse_secctx. >>>>>>>>> This contains total size of security context which follows this structure. >>>>>>>>> >>>>>>>>> - xattr name string. >>>>>>>>> This string represents name of xattr which should be used while setting >>>>>>>>> security context. As of now it is hardcoded to "security.selinux". >>>>>>>> Any reason not to just send all `security.*` xattrs found on the inode? >>>>>>>> >>>>>>>> (I'm not super familiar with this code, it looks like we're going from the LSM-cached version attached to the inode, but presumably since we're sending bytes we can just ask the filesytem for the raw data instead) >>>>>>> So this inode is about to be created. There are no xattrs yet. And >>>>>>> filesystem is asking LSMs, what security labels should be set on this >>>>>>> inode before it is published. >>>>>> No. That's imprecise. It's what SELinux does. An LSM can add any >>>>>> number of attributes on inode creation, or none. These attributes >>>>>> may or may not be "security labels". Assuming that they are is the >>>>>> kind of thinking that leads people like Linus to conclude that the >>>>>> LSM community is clueless. >>>>>> >>>>>> >>>>>>> For local filesystems it is somewhat easy. They are the one creating >>>>>>> inode and can set all xattrs/labels before inode is added to inode >>>>>>> cache. >>>>>>> >>>>>>> But for remote like filesystems, it is more tricky. Actual inode >>>>>>> creation first will happen on server and then client will instantiate >>>>>>> an inode based on information returned by server (Atleast that's >>>>>>> what fuse does). >>>>>>> >>>>>>> So security_dentry_init_security() was created (I think by NFS folks) >>>>>>> so that they can query the label and send it along with create >>>>>>> request and server can take care of setting label (along with file >>>>>>> creation). >>>>>>> >>>>>>> One limitation of security_dentry_init_security() is that it practically >>>>>>> supports only one label. And only SELinux has implemented. So for >>>>>>> all practical purposes this is a hook to obtain selinux label. NFS >>>>>>> and ceph already use it in that way. >>>>>>> >>>>>>> Now there is a desire to be able to return more than one security >>>>>>> labels and support smack and possibly other LSMs. Sure, that great. >>>>>>> But I think for that we will have to implement a new hook which >>>>>>> can return multiple labels and filesystems like nfs, ceph and fuse >>>>>>> will have to be modified to cope with this new hook to support >>>>>>> multiple lables. >>>>>>> >>>>>>> And I am arguing that we can modify fuse when that hook has been >>>>>>> implemented. There is no point in adding that complexity in fuse >>>>>>> code as well all fuse-server implementations when there is nobody >>>>>>> generating multiple labels. We can't even test it. >>>>>> There's a little bit of chicken-and-egg going on here. >>>>>> There's no point in accommodating multiple labels in >>>>>> this code because you can't have multiple labels. There's >>>>>> no point in trying to support multiple labels because >>>>>> you can't use them in virtiofs and a bunch of other >>>>>> places. >>>>> Once security subsystem provides a hook to support multiple lables, then >>>>> atleast one filesystem will have to be converted to make use of this new >>>>> hook at the same time and rest of the filesystems can catch up later. >>>> Clearly you haven't been following the work I've been doing on >>>> module stacking. That's completely understandable. There aren't >>>> new hooks being added, or at least haven't been yet. Some of the >>>> existing hooks are getting changed to provide the data required >>>> for multiple security modules (e.g. secids become a set of secids). >>>> Filesystems that support xattrs properly are unaffected because, >>>> for all it's shortcomings, the LSM layer hides the details of >>>> the security modules sufficiently. >>>> >>>> Which filesystem are you saying will have to "be converted"? >>> When I grep for "security_dentry_init_security()" in current code, >>> I see two users, ceph and nfs. >> Neither of which support xattrs fully. Ceph can support them properly, >> but does not by default. NFS is ancient and we've talked about it at >> length. Also, the fact that they use security_dentry_init_security() >> is a red herring. Really, this has no bearing on the issue of fuse. > Frankly speaking, I am now beginning to lose what's being asked for, > w.r.t this patch. 1. Support for multiple concurrent security.* xattrs 2. Abandon mapping security.* attrs to user.* xattrs > I see that NFS and ceph are supporting single security label at > the time of file creation and I added support for the same for > fuse. NFS took that course because the IETF refused for a very long time to accept a name+value pair in the protocol. The implementation was a compromise. > > You seem to want to have capability to send multiple "name,value,len" > tuples so that you can support multiple xattrs/labels down the > line. No, so I can do it now. Smack keeps multiple xattrs on filesystem objects. security.SMACK64 - the "security label" security.SMACK64EXEC - the Smack label to run the program with security.SMACK64TRANSMUTE - controls labeling on files created There has been discussion about using additional attributes for things like socket labeling. This isn't hypothetical. It's real today. > Even if I do that, I am not sure what to do with those xattrs at > the other end. I am using /proc/thread-self/attr/fscreate to > set the security attribute of file. Either you don't realize that attr/fscreate is SELinux specific, or you don't care, or possibly (and sadly) both. > > https://listman.redhat.com/archives/virtio-fs/2021-September/msg00100.html > > How will this work with multiple labels. I think you will have to > extend fscreate or create new interface to be able to deal with it. Yeah. That thread didn't go to the LSM mail list. It was essentially kept within the RedHat SELinux community. It's no wonder everyone involved thought that your approach is swell. No one who would get goobsmacked by it was on the thread. > > That's why I think that it seems premature that fuse interface be > written to deal with multiple labels when rest of the infrastructure > is not ready. It should be other way, instead. First rest of the > infrastructure should be written and then all the users make use > of new infra. Today the LSM infrastructure allows a security module to use as many xattrs as it likes. Again, Smack uses multiple security.* xattrs today. > BTW, I am checking security_inode_init_security(). That seems to > return max 2 xattrs as of now? > > #define MAX_LSM_EVM_XATTR 2 > struct xattr new_xattrs[MAX_LSM_EVM_XATTR + 1]; You're looking at the bowels of the EVM subsystem. That herring is red, too. > So we are allocating space for 3 xattrs. Last xattr is Null to signify > end of array. So, we seem to use on xattr for LSM and another for EVM. > Do I understand it correctly. Does that mean that smack stuff does > not work even with security_inode_init_security(). Or there is something > else going on. There's something else going on. > > Vivek > >>> fs/ceph/xattr.c >>> ceph_security_init_secctx() >>> >>> fs/nfs/nfs4proc.c >>> nfs4_label_init_security() >>> >>> So looks like these two file systems will have to be converted >>> (along with fuse). >>> >>> Vivek >>> >>>> NFS is going to require some work, but that's because it was >>>> done as a special case for "MAC labels". The NFS support for >>>> security.* xattrs came much later. This is one of the reasons >>>> why I'm concerned about the virtiofs implementation you're >>>> proposing. We were never able to get the NFS "MAC label" >>>> implementation to work properly with Smack, even though there is >>>> no obvious reason it wouldn't. >>>> >>>> >>>>> Vivek >>>>>
