On 9/22/2021 4:35 PM, Al Viro wrote:
On Wed, Sep 22, 2021 at 01:52:18PM +0200, David Disseldorp wrote:
do_header() is called for each cpio entry and first checks for "newc"
magic before parsing further. The magic check includes a special case
error message if POSIX.1 ASCII (cpio -H odc) magic is detected. This
special case POSIX.1 check needn't be done in the hot path, so move it
under the non-newc-magic error path.
You keep refering to hot paths; do you have any data to support that
assertion?
How much does that series buy you on average, and what kind of dispersion
do you get before and after it?
I'm not saying I hate the patches themselves, but those references in commit
messages ping my BS detectors every time I see them ;-/
And this exactly why cover-letter with a quantitative date for such
series is important based on my experience...
