On Mon, Sep 20, 2021 at 01:14:15PM +0100, David Howells wrote: > +++ b/fs/9p/vfs_addr.c > @@ -88,7 +88,7 @@ static const struct netfs_read_request_ops v9fs_req_ops = { > > /** > * v9fs_vfs_readpage - read an entire page in from 9P > - * @filp: file being read > + * @file: file being read > * @page: structure to page > * > */ This is an example of a weird pattern in filesystems. Several of them have kernel-doc for the implementation of various ->ops methods. I don't necessarily believe we should delete the comments (although is there any useful information in the above?), but I don't see the point in the comment being kernel-doc.