Re: [PATCH v3 8/8] treewide: Replace the use of mem_encrypt_active() with cc_platform_has()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/8/21 10:58 PM, Tom Lendacky wrote:

diff --git a/arch/powerpc/include/asm/mem_encrypt.h b/arch/powerpc/include/asm/mem_encrypt.h
index ba9dab07c1be..2f26b8fc8d29 100644
--- a/arch/powerpc/include/asm/mem_encrypt.h
+++ b/arch/powerpc/include/asm/mem_encrypt.h
@@ -10,11 +10,6 @@
#include <asm/svm.h> -static inline bool mem_encrypt_active(void)
-{
-	return is_secure_guest();
-}
-
  static inline bool force_dma_unencrypted(struct device *dev)
  {
  	return is_secure_guest();
diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c
index 87f001b4c4e4..c083ecbbae4d 100644
--- a/arch/powerpc/platforms/pseries/svm.c
+++ b/arch/powerpc/platforms/pseries/svm.c
@@ -8,6 +8,7 @@
#include <linux/mm.h>
  #include <linux/memblock.h>
+#include <linux/cc_platform.h>
  #include <asm/machdep.h>
  #include <asm/svm.h>
  #include <asm/swiotlb.h>
@@ -63,7 +64,7 @@ void __init svm_swiotlb_init(void)
int set_memory_encrypted(unsigned long addr, int numpages)
  {
-	if (!mem_encrypt_active())
+	if (!cc_platform_has(CC_ATTR_MEM_ENCRYPT))
  		return 0;
if (!PAGE_ALIGNED(addr))
@@ -76,7 +77,7 @@ int set_memory_encrypted(unsigned long addr, int numpages)
int set_memory_decrypted(unsigned long addr, int numpages)
  {
-	if (!mem_encrypt_active())
+	if (!cc_platform_has(CC_ATTR_MEM_ENCRYPT))
  		return 0;
if (!PAGE_ALIGNED(addr))

This change unnecessarily complexifies the two functions. This is due to cc_platform_has() being out-line. It should really remain inline.

Before the change we got:

0000000000000000 <.set_memory_encrypted>:
   0:	7d 20 00 a6 	mfmsr   r9
   4:	75 29 00 40 	andis.  r9,r9,64
   8:	41 82 00 48 	beq     50 <.set_memory_encrypted+0x50>
   c:	78 69 04 20 	clrldi  r9,r3,48
  10:	2c 29 00 00 	cmpdi   r9,0
  14:	40 82 00 4c 	bne     60 <.set_memory_encrypted+0x60>
  18:	7c 08 02 a6 	mflr    r0
  1c:	7c 85 23 78 	mr      r5,r4
  20:	78 64 85 02 	rldicl  r4,r3,48,20
  24:	61 23 f1 34 	ori     r3,r9,61748
  28:	f8 01 00 10 	std     r0,16(r1)
  2c:	f8 21 ff 91 	stdu    r1,-112(r1)
  30:	48 00 00 01 	bl      30 <.set_memory_encrypted+0x30>
			30: R_PPC64_REL24	.ucall_norets
  34:	60 00 00 00 	nop
  38:	38 60 00 00 	li      r3,0
  3c:	38 21 00 70 	addi    r1,r1,112
  40:	e8 01 00 10 	ld      r0,16(r1)
  44:	7c 08 03 a6 	mtlr    r0
  48:	4e 80 00 20 	blr
  50:	38 60 00 00 	li      r3,0
  54:	4e 80 00 20 	blr
  60:	38 60 ff ea 	li      r3,-22
  64:	4e 80 00 20 	blr

After the change we get:

0000000000000000 <.set_memory_encrypted>:
   0:	7c 08 02 a6 	mflr    r0
   4:	fb c1 ff f0 	std     r30,-16(r1)
   8:	fb e1 ff f8 	std     r31,-8(r1)
   c:	7c 7f 1b 78 	mr      r31,r3
  10:	38 60 00 00 	li      r3,0
  14:	7c 9e 23 78 	mr      r30,r4
  18:	f8 01 00 10 	std     r0,16(r1)
  1c:	f8 21 ff 81 	stdu    r1,-128(r1)
  20:	48 00 00 01 	bl      20 <.set_memory_encrypted+0x20>
			20: R_PPC64_REL24	.cc_platform_has
  24:	60 00 00 00 	nop
  28:	2c 23 00 00 	cmpdi   r3,0
  2c:	41 82 00 44 	beq     70 <.set_memory_encrypted+0x70>
  30:	7b e9 04 20 	clrldi  r9,r31,48
  34:	2c 29 00 00 	cmpdi   r9,0
  38:	40 82 00 58 	bne     90 <.set_memory_encrypted+0x90>
  3c:	38 60 00 00 	li      r3,0
  40:	7f c5 f3 78 	mr      r5,r30
  44:	7b e4 85 02 	rldicl  r4,r31,48,20
  48:	60 63 f1 34 	ori     r3,r3,61748
  4c:	48 00 00 01 	bl      4c <.set_memory_encrypted+0x4c>
			4c: R_PPC64_REL24	.ucall_norets
  50:	60 00 00 00 	nop
  54:	38 60 00 00 	li      r3,0
  58:	38 21 00 80 	addi    r1,r1,128
  5c:	e8 01 00 10 	ld      r0,16(r1)
  60:	eb c1 ff f0 	ld      r30,-16(r1)
  64:	eb e1 ff f8 	ld      r31,-8(r1)
  68:	7c 08 03 a6 	mtlr    r0
  6c:	4e 80 00 20 	blr
  70:	38 21 00 80 	addi    r1,r1,128
  74:	38 60 00 00 	li      r3,0
  78:	e8 01 00 10 	ld      r0,16(r1)
  7c:	eb c1 ff f0 	ld      r30,-16(r1)
  80:	eb e1 ff f8 	ld      r31,-8(r1)
  84:	7c 08 03 a6 	mtlr    r0
  88:	4e 80 00 20 	blr
  90:	38 60 ff ea 	li      r3,-22
  94:	4b ff ff c4 	b       58 <.set_memory_encrypted+0x58>




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux