Re: [PATCH v2 1/7] binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>
Subject: Re: [PATCH v2 1/7] binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Sun, 5 Sep 2021 21:07:48 +0200
Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, Petr Mladek <pmladek@xxxxxxxx>, Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Greg Ungerer <gerg@xxxxxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Vincenzo Frascino <vincenzo.frascino@xxxxxxx>, Chinwen Chang <chinwen.chang@xxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>, Huang Ying <ying.huang@xxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Feng Tang <feng.tang@xxxxxxxxx>, Kevin Brodsky <Kevin.Brodsky@xxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Shawn Anastasio <shawn@xxxxxxxxxx>, Steven Price <steven.price@xxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christian Brauner <christian.brauner@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Shakeel Butt <shakeelb@xxxxxxxxxx>, Marco Elver <elver@xxxxxxxxxx>, Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>, Nicolas Viennot <Nicolas.Viennot@xxxxxxxxxxxx>, Thomas Cedeno <thomascedeno@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Chengguang Xu <cgxu519@xxxxxxxxxxxx>, Christian König <ckoenig.leichtzumerken@xxxxxxxxx>, Florian Weimer <fweimer@xxxxxxxxxx>, David Laight <David.Laight@xxxxxxxxxx>, linux-unionfs@xxxxxxxxxxxxxxx, Linux API <linux-api@xxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Linux-MM <linux-mm@xxxxxxxxx>
In-reply-to: <CAHk-=whO-dnNxz5H8yfnGsNxrDHu-TVQq-X-VwhoDyWu3Lgnyg@mail.gmail.com>
Organization: Red Hat
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 05.09.21 19:17, Linus Torvalds wrote:

On Sun, Sep 5, 2021 at 8:32 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:


Guess someone didn't care compile testing their code. This is now in
mainline.


To be fair, a.out is disabled pretty much on all relevant platforms these days.

Yes, and it seems like it was disabled in all configs I used. (I did notcompile all-yes configs; usually my stuff goes via -mm where it will endup in -next for a while ... this one was special)


Only alpha and m68k left, I think.

I applied the obvious patch from Geert.


Thanks Linus!


--
Thanks,

David / dhildenb

References:
- [PATCH v2 0/7] Remove in-tree usage of MAP_DENYWRITE
  - From: David Hildenbrand
- [PATCH v2 1/7] binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()
  - From: David Hildenbrand
- Re: [PATCH v2 1/7] binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()
  - From: Guenter Roeck
- Re: [PATCH v2 1/7] binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()
  - From: Linus Torvalds

Prev by Date: Re: Report Bug to Linux File System about fs/devpts
Next by Date: Re: [PATCH] binfmt: a.out: Fix bogus semicolon
Previous by thread: Re: [PATCH v2 1/7] binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()
Next by thread: [PATCH v2 2/7] kernel/fork: factor out replacing the current MM exe_file
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]