Reviewed-by: Joel Becker <jlbec@xxxxxxxxxxxx> On Wed, Aug 25, 2021 at 08:49:03AM +0200, Christoph Hellwig wrote: > Just like most other file systems: get the simple checks out of the > way first. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > fs/configfs/dir.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c > index ac5e0c0e9181..cf08bbde55f3 100644 > --- a/fs/configfs/dir.c > +++ b/fs/configfs/dir.c > @@ -456,6 +456,9 @@ static struct dentry * configfs_lookup(struct inode *dir, > int found = 0; > int err; > > + if (dentry->d_name.len > NAME_MAX) > + return ERR_PTR(-ENAMETOOLONG); > + > /* > * Fake invisibility if dir belongs to a group/default groups hierarchy > * being attached > @@ -486,8 +489,6 @@ static struct dentry * configfs_lookup(struct inode *dir, > * If it doesn't exist and it isn't a NOT_PINNED item, > * it must be negative. > */ > - if (dentry->d_name.len > NAME_MAX) > - return ERR_PTR(-ENAMETOOLONG); > d_add(dentry, NULL); > return NULL; > } > -- > 2.30.2 > --
