> From: Kari Argillander <kari.argillander@xxxxxxxxx> > Sent: Tuesday, August 24, 2021 11:22 AM > To: Christoph Hellwig <hch@xxxxxx> > Cc: Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>; ntfs3@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > fsdevel@xxxxxxxxxxxxxxx; Pali Rohár <pali@xxxxxxxxxx>; Matthew Wilcox <willy@xxxxxxxxxxxxx>; Christian Brauner > <christian.brauner@xxxxxxxxxx> > Subject: Re: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting > > On Tue, Aug 24, 2021 at 10:03:02AM +0200, Christoph Hellwig wrote: > > > + /* > > > + * TODO: We should probably check some mount options does > > > + * they all work after remount. Example can we really change > > > + * nls. Remove this comment when all testing is done or > > > + * even better xfstest is made for it. > > > + */ > > > > Instead of the TODO I would suggest a prep patch to drop changing of > > any options in remount before this one and then only add them back > > as needed and tested. > > This could be good option. I have actually tested nls and it will be > problem so we definitely drop that. I will wait what Konstantin has > to say about other. > > > The mechanics of the conversion look good to me. > > I have made quite few changes to make this series better and will > send v3 in the near future. > > Main change is that we won't allocate sbi when remount. We can > allocate just options. Also won't let nls/iocharset change. Hi Kari, looking forward to have v3 series to pick up! Best regards.
