On Thu, Aug 19, 2021 at 9:12 PM Christoph Hellwig <hch@xxxxxx> wrote: > > On Thu, Aug 19, 2021 at 02:25:52PM -0700, Dan Williams wrote: > > Given most of the iomap_iter users don't care about srcmap, i.e. are > > not COW cases, they are leaving srcmap zero initialized. Should the > > IOMAP types be incremented by one so that there is no IOMAP_HOLE > > confusion? In other words, fold something like this? > > A hole really means nothing to read from the source. The existing code > also relies on that. Ok, I've since found iomap_iter_srcmap(). Sorry for the noise.