On Sun, Aug 8, 2021 at 11:19 PM Christoph Hellwig <hch@xxxxxx> wrote: I'd prefer a non-empty changelog that said something like: "In preparation for iomap_iter() update iomap helpers to treat the iomap argument as read-only." Just to leave a breadcrumb for the motivation for this change, but no major worry if you don't respin for that. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> Otherwise, LGTM Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>