On Thursday 19 August 2021 04:21:08 Kari Argillander wrote: > On Sun, Aug 08, 2021 at 06:24:38PM +0200, Pali Rohár wrote: > > Other fs drivers are using iocharset= mount option for specifying charset. > > So mark iocharset= mount option as preferred and deprecate nls= mount > > option. > > One idea is also make this change to fs/fc_parser.c and then when we > want we can drop support from all filesystem same time. This way we > can get more deprecated code off the fs drivers. Draw back is that > then every filesstem has this deprecated nls= option if it support > iocharsets option. But that should imo be ok. Beware that iocharset= is required only for fs which store filenames in some specific encoding (in this case extension to UTF-16). For fs which store filenames in raw bytes this option should not be parsed at all. Therefore I'm not sure if this parsing should be in global fs/fc_parser.c file...
