On Mon, Aug 16, 2021 at 02:17:52PM +0200, Christoph Hellwig wrote: > On Mon, Aug 16, 2021 at 06:23:51AM +0300, Kari Argillander wrote: > > > Nls loading is changed a little bit because new api not have default > > > optioni for mount parameters. So we need to load nls table before and > > > change that if user specifie someting else. > > > > > > Also try to use fsparam_flag_no as much as possible. This is just nice > > > little touch and is not mandatory but it should not make any harm. It > > > is just convenient that we can use example acl/noacl mount options. > > > > I would like that if someone can comment can we do reconfigure so that > > we change mount options? Can we example change iocharset and be ok after > > that? I have look some other fs drivers and in my eyes it seems to be > > quite random if driver should let reconfigure all parameters. Right now > > code is that we can reconfigure every mount parameter but I do not know > > if this is right call. > > Reconfiguring non-trivial mount parameters is hard. In general I'd > recommend to only allow reconfiguring paramters that > > a) have user demand for that > b) you know what you're actually doing. > > Something like the iocharset clearly isn't something that makes sense > to be changed. I will probably do this series so that nothing can be changed but that there will be easy way to enable changing in code. So after I can send small patch which will enable changing and I can test each option separately. If Konstantin can comment if there is some parameters which have real demand then I will of course implement those. Thanks for comments.
