On Fri, Aug 13, 2021 at 12:41 AM Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> wrote: > > Like inode events, FAN_FS_ERROR will require fid mode. Therefore, > convert the verification during fanotify_mark(2) to require fid for any > non-fd event. This means fid_mode will not only be required for inode > events, but for any event that doesn't provide a descriptor. > > Suggested-by: Amir Goldstein <amir73il@xxxxxxxxx> > Reviewed-by: Jan Kara <jack@xxxxxxx> > Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> > > --- > changes since v5: > - Fix condition to include FANOTIFY_EVENT_FLAGS. (me) > - Fix comment identation (jan) > --- > fs/notify/fanotify/fanotify_user.c | 12 ++++++------ > include/linux/fanotify.h | 3 +++ > 2 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c > index 4cacea5fcaca..54107f1533d5 100644 > --- a/fs/notify/fanotify/fanotify_user.c > +++ b/fs/notify/fanotify/fanotify_user.c > @@ -1387,14 +1387,14 @@ static int do_fanotify_mark(int fanotify_fd, unsigned int flags, __u64 mask, > goto fput_and_out; > > /* > - * Events with data type inode do not carry enough information to report > - * event->fd, so we do not allow setting a mask for inode events unless > - * group supports reporting fid. > - * inode events are not supported on a mount mark, because they do not > - * carry enough information (i.e. path) to be filtered by mount point. > + * Events that do not carry enough information to report > + * event->fd require a group that supports reporting fid. Those > + * events are not supported on a mount mark, because they do not > + * carry enough information (i.e. path) to be filtered by mount > + * point. > */ > fid_mode = FAN_GROUP_FLAG(group, FANOTIFY_FID_BITS); > - if (mask & FANOTIFY_INODE_EVENTS && > + if (mask & ~(FANOTIFY_FD_EVENTS|FANOTIFY_EVENT_FLAGS) && > (!fid_mode || mark_type == FAN_MARK_MOUNT)) > goto fput_and_out; > > diff --git a/include/linux/fanotify.h b/include/linux/fanotify.h > index a16dbeced152..c05d45bde8b8 100644 > --- a/include/linux/fanotify.h > +++ b/include/linux/fanotify.h > @@ -81,6 +81,9 @@ extern struct ctl_table fanotify_table[]; /* for sysctl */ > */ > #define FANOTIFY_DIRENT_EVENTS (FAN_MOVE | FAN_CREATE | FAN_DELETE) > > +/* Events that can be reported with event->fd */ > +#define FANOTIFY_FD_EVENTS (FANOTIFY_PATH_EVENTS | FANOTIFY_PERM_EVENTS) > + > /* Events that can only be reported with data type FSNOTIFY_EVENT_INODE */ > #define FANOTIFY_INODE_EVENTS (FANOTIFY_DIRENT_EVENTS | \ > FAN_ATTRIB | FAN_MOVE_SELF | FAN_DELETE_SELF) > -- > 2.32.0 >
