Re: [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page()
From: John Hubbard <jhubbard@xxxxxxxxxx>
Date: Thu, 12 Aug 2021 14:59:33 -0700
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, <linux-mm@xxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>
In-reply-to: <20210812092043.GA4827@lst.de>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 8/12/21 2:20 AM, Christoph Hellwig wrote:

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Note: the __maybe_unused on try_grab_compound_head should be dropped now
that there is always a user.



Good point, fixed in v3.


thanks,
--
John Hubbard
NVIDIA

References:
- [PATCH v2 0/3] A few gup refactorings and documentation updates
  - From: John Hubbard
- [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page()
  - From: John Hubbard
- Re: [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page()
  - From: Christoph Hellwig

Prev by Date: [PATCH v6 21/21] docs: Document the FAN_FS_ERROR event
Next by Date: Re: Questions re the new mount_setattr(2) manual page
Previous by thread: Re: [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page()
Next by thread: [PATCH] ramfs: fix mount source show for ramfs
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]