On Mon, Jul 26, 2021 at 12:27:56PM +0200, Christian Brauner wrote: > +/** > + * lookup_mapped_one_len - filesystem helper to lookup single pathname component Can we think about the name a bit? In the ur-times (2.3.99), we had lookup_dentry(), which as far as I can tell walked an entire path. That got augmented with lookup_one() which just walked a single path entry. That was replaced with lookup_one_len() which added the 'len' parameter. Now we have: struct dentry *try_lookup_one_len(const char *, struct dentry *, int); struct dentry *lookup_one_len(const char *, struct dentry *, int); struct dentry *lookup_one_len_unlocked(const char *, struct dentry *, int); struct dentry *lookup_positive_unlocked(const char *, struct dentry *, int); I think the 'len' part of the name has done its job, and this new helper should be 'lookup_one_mapped'.