On Fri, Jul 23, 2021 at 12:10:32AM +0000, Al Viro wrote: > On Thu, Jul 22, 2021 at 05:42:55PM -0600, Jens Axboe wrote: > > > > So how can we possibly get there with tsk->files == NULL and what does it > > > have to do with files, anyway? > > > > It's not the clearest, but the files check is just to distinguish between > > exec vs normal cancel. For exec, we pass in files == NULL. It's not > > related to task->files being NULL or not, we explicitly pass NULL for > > exec. > > Er... So turn that argument into bool cancel_all, and pass false on exit and > true on exit? ^^^^ exec, that is. Sorry.