On Tue, Jul 20, 2021 at 01:10:04PM +0100, Matthew Wilcox wrote: > On Tue, Jul 20, 2021 at 10:43:20AM +0200, Christoph Hellwig wrote: > > Now that the outstanding writes are counted in bytes, there is no need > > to use the low-level __bio_try_merge_page API, we can switch back to > > always using bio_add_page and simply iomap_add_to_ioend again. > > These two callers were the only external users of __bio_try_merge_page(), > so it can now be made static to block/bio.c. Yeah, but doing so in the same merge window will create an annoying cross dependency. I have a series to cleanup a whole lot of the bio_add_page related code including starting to clean up the return value for the next merge window.