Hi Christoph, On Wed, Jul 14, 2021 at 05:18:07PM +0100, Christoph Hellwig wrote: > On Wed, Jul 14, 2021 at 09:13:52AM -0700, Darrick J. Wong wrote: > > Porting to fs/iomap can be done after merge, so long as the ntfs3 > > driver doesn't depend on crazy reworking of buffer heads or whatever. > > AFAICT it didn't, so ... yes, my earlier statements still apply: "later > > as a clean up". > > I on the other hand hate piling up mor of this legacy stuff, as it tends > to not be cleaned up by the submitted. Example: erofs still hasn't > switched to iomap despite broad claims, also we still have a huge Just some word of this, I've been always actively developing and converting legacy stuffs to new APIs these years, such as new mount APIs, xarray, which can be seen by changelog compared with other filesystems. The iomap buffered I/O stuff is mainly because it doesn't support tailing-packing inline, although which has been requested for people who cares more about storage itself, like: https://lore.kernel.org/lkml/3dbeff43-0905-3421-4652-41b7a935f3c1@xxxxxxxxx/ And I can also show the benefits by using tailing-packing inline by taking Linux source code tree (many random tail blocks) as an example... I'm now working on this tailing-packing inline iomap support as well. But Anyway, erofs didn't use buffer head in the beginning since I can see some flew of buffer head approach itself, it just works on raw bio and page cache interfaces for now. Thanks, Gao Xiang > backlog in the switch to the new mount API.
