Re: [PATCH 2/3] afs: check function return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marc Dionne <marc.c.dionne@xxxxxxxxx> wrote:

> > @@ -777,7 +777,7 @@ int afs_writepages(struct address_space *mapping,
> >                 mapping->writeback_index = next / PAGE_SIZE;
> 
> Isn't there the same issue with the use of next here.

Good point.

> >                         mapping->writeback_index = next;
> 
> Unrelated to this patch, but since next is a byte offset, should this
> also divide by PAGE_SIZE as above.

Also a good point.  I'll whip up a separate patch for that.

David




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux