On Sun, Jul 11, 2021 at 07:54:11PM +0200, Matteo Croce wrote: > +void inc_diskseq(struct gendisk *disk) > +{ > + disk->diskseq = atomic64_inc_return(&diskseq); > +} > +EXPORT_SYMBOL_GPL(inc_diskseq); No need to export inc_diskseq in the new world order. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>