On Thu, Jul 8, 2021 at 2:26 AM Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Jul 7, 2021 at 5:28 AM Dmitry Kadashev <dkadashev@xxxxxxxxx> wrote: > > > > This started out as an attempt to add mkdirat support to io_uring which > > is heavily based on renameat() / unlinkat() support. > > Ok, sorry for having made you go through all the different versions, > but I like the new series and think it's a marked improvement. No worries at all! > I did send out a few comments to the individual patches that I think > it can all now be made to be even more legible by avoiding some of the > goto spaghetti, but I think that would be a series on top. > > (And I'd like to note again that I based all that on just reading the > patches, so there may be something there that makes it not work well). I'm happy to do that. I suppose it will have to go through Al's tree rather than Jens' one? > One final request: can you keep the fs/namei.c patches as one entirely > separate series, and then do the io_uring parts at the end, rather > than intermixing them? Sure. I'm a bit confused if you mean splitting the series into two or just moving io_uring bits to the end though. I'll send a v9 with io_uring bits moved to the end of the series and if you prefer it to be a completely separate series then let me know. Thank you for the help again, Linus! -- Dmitry Kadashev