On Wed, Jul 7, 2021 at 5:28 AM Dmitry Kadashev <dkadashev@xxxxxxxxx> wrote: > > Pass in the struct filename pointers instead of the user string, for > uniformity with the recently converted do_unlinkat(), do_renameat(), > do_mkdirat(). Yup. And the uniformity continues with that "we could avoid the goto retry/out1 with a mknodat_helper() function for the inner meat of the function. Linus