On Wed, Jul 7, 2021 at 5:28 AM Dmitry Kadashev <dkadashev@xxxxxxxxx> wrote: > > Pass in the struct filename pointers instead of the user string, and > update the three callers to do the same. This is heavily based on > commit dbea8d345177 ("fs: make do_renameat2() take struct filename"). > > This behaves like do_unlinkat() and do_renameat2(). .. and now I like this version too. And that do_mkdirat() could have the same pattern with a "mkdirat_helper()" and avoiding the "goto retry" and "goto out_putname" things, and be more understandable that way. Again, that could - and maybe should - be a separate cleanup. Linus