J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > And the test failure > is nfsd_lookup() returning OK on a directory when it should return > nfserr_perm. I assume that's the result of inode_permission(directory > inode, MAY_EXEC) returning 0 when it shouldn't, but I haven't confirmed > that. The first problem directly related to this is, I think, addressed by the attached patch. There seems to be more to it, though. David --- diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c index 0184fe9..64bc1f5 100644 --- a/fs/nfsd/auth.c +++ b/fs/nfsd/auth.c @@ -76,7 +76,7 @@ int nfsd_setuser(struct svc_rqst *rqstp, struct svc_export *exp) ret = set_groups(new, gi); put_group_info(gi); - if (!ret) + if (ret < 0) goto error; if (new->uid) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
